Add new CompositionOption to bail if total number of subgraph path infos in the stack gets above a configured value. #3254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fos in the stack gets above a configured value.
🦋 Changeset detectedLatest commit: a657a82 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 88dcda14f9857e3a84b1d6e7 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
duckki
reviewed
May 14, 2025
Contributor
duckki
left a comment
duckki
left a comment
There was a problem hiding this comment.
Look reasonable. Just a question.
sachindshinde
requested changes
May 15, 2025
Contributor
There was a problem hiding this comment.
Note that #3258 should help for the subgraph path issues we've been considering, but it would still be good to have this limit if there's other undiscovered issues.
sachindshinde
approved these changes
May 29, 2025
dariuszkuc
pushed a commit
that referenced
this pull request
Jun 24, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @apollo/[email protected] ### Patch Changes - Adding new CompositionOption `maxValidationSubgraphPaths`. This value represents the maximum number of SubgraphPathInfo objects that may exist in a ValidationTraversal when checking for satisfiability. Setting this value can help composition error before running out of memory. Default is 1,000,000. ([#3254](#3254)) - Fix bug in composition where, when a field's type in a subgraph is a subtype of the field's type in the supergraph, the satisfiability validation spuriously succeeds/errors. ([#3277](#3277)) - Updated dependencies \[[`7799ad1717becf15fb0e82f89619f2ec8a24b4d4`](7799ad1), [`b26794c5724ef23d1f0fd45a40aee3d301557489`](b26794c), [`51bed5be49d8e87adae59f568315c9e3488a91e0`](51bed5b)]: - @apollo/[email protected] - @apollo/[email protected] ## @apollo/[email protected] ### Patch Changes - Updated dependencies \[[`7799ad1717becf15fb0e82f89619f2ec8a24b4d4`](7799ad1), [`b26794c5724ef23d1f0fd45a40aee3d301557489`](b26794c), [`51bed5be49d8e87adae59f568315c9e3488a91e0`](51bed5b)]: - @apollo/[email protected] - @apollo/[email protected] - @apollo/[email protected] ## @apollo/[email protected] ### Patch Changes - fix: make composeDirective argument non-nullable. ([#3278](#3278)) Per our [docs](https://www.apollographql.com/docs/graphos/schema-design/federated-schemas/reference/directives#composedirective), `@composeDirective` requires non-nullable value to be passed as an argument. Our [validations](https://github.com/apollographql/federation/blob/main/composition-js/src/composeDirectiveManager.ts#L250-L255) were checking for valid values (it has to be a string that starts with `@`), but the generated schema was incorrectly specifying that the argument was nullable. - Adding new CompositionOption `maxValidationSubgraphPaths`. This value represents the maximum number of SubgraphPathInfo objects that may exist in a ValidationTraversal when checking for satisfiability. Setting this value can help composition error before running out of memory. Default is 1,000,000. ([#3254](#3254)) ## @apollo/[email protected] ### Patch Changes - Fix bug in composition where, when a field's type in a subgraph is a subtype of the field's type in the supergraph, the satisfiability validation spuriously succeeds/errors. ([#3277](#3277)) - Updated dependencies \[[`7799ad1717becf15fb0e82f89619f2ec8a24b4d4`](7799ad1), [`b26794c5724ef23d1f0fd45a40aee3d301557489`](b26794c)]: - @apollo/[email protected] ## @apollo/[email protected] ### Patch Changes - Updated dependencies \[[`7799ad1717becf15fb0e82f89619f2ec8a24b4d4`](7799ad1), [`b26794c5724ef23d1f0fd45a40aee3d301557489`](b26794c), [`51bed5be49d8e87adae59f568315c9e3488a91e0`](51bed5b)]: - @apollo/[email protected] - @apollo/[email protected] ## @apollo/[email protected] ### Patch Changes - Updated dependencies \[[`7799ad1717becf15fb0e82f89619f2ec8a24b4d4`](7799ad1), [`b26794c5724ef23d1f0fd45a40aee3d301557489`](b26794c)]: - @apollo/[email protected] ## [email protected] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.